deduplicate package instructions#2013
Merged
Merged
Conversation
henderkes
commented
Nov 21, 2025
henderkes
commented
Nov 21, 2025
| sudo dnf install php-zts-apcu # or apt | ||
| ``` | ||
|
|
||
| If an extension is not available by default, install it with pie |
Contributor
Author
There was a problem hiding this comment.
We have a section about pie below Homebrew. Docker is missing extension installation instructions here. Perhaps we can pull these together.
henderkes
commented
Nov 25, 2025
henderkes
commented
Nov 25, 2025
Contributor
Author
|
@dunglas could we get this into the patch release? no new features, just a bit of cleanup to prevent confusion for users. |
dunglas
reviewed
Nov 25, 2025
dunglas
approved these changes
Nov 25, 2025
henderkes
commented
Nov 25, 2025
|
|
||
| ```console | ||
| brew install dunglas/frankenphp/frankenphp | ||
| sudo systemctl start frankenphp |
Contributor
Author
There was a problem hiding this comment.
I skipped on adding a note about enabling the service... I think we don't have to explain systemd here, just mention that the service exists.
henderkes
commented
Nov 25, 2025
| # Add extra Caddy modules and FrankenPHP extensions here | ||
| # optionally, if you would like to compile from your frankenphp sources: | ||
| # --with github.com/dunglas/frankenphp=$(pwd) \ | ||
| # --with github.com/dunglas/frankenphp/caddy=$(pwd)/caddy |
Contributor
Author
There was a problem hiding this comment.
yes, simply adding this works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw it live on the website just now and the comments are more prominent than the instructions. Trying to simplify it a bit, ideas are welcome.
Edit: closes #2017